#141680: "incorrect score display"
Bu rapor neyle alakali?
Ne oldu? Lütfen aşağıdan seçin
Ne oldu? Lütfen aşağıdan seçin
Lütfen aynı konuda bir rapor olup olmadığını kontrol edin
Eğer evet ise, lütfen bu rapor için oy verin. En çok oy alan raporlar ÖNCELİKLİ!
| # | Status | Votes | Game | Type | Title | Last update |
|---|
Detayli tanim
-
• Eğer varsa, lütfen ekranda gördüğünüz hata mesajını kopyalayın/yapıştırın.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Lütfen ne yapmak istediğini, ne yaptığını ve ne olduğunu açıkla.
• Hangi browseri kullaniyorsun?
opera
-
• Lütfen görüntülenen metni kendi diliniz yerine İngilizce olarak kopyalayın/yapıştırın. If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here. Bu metin çeviri sisteminde mevcut mu? Evet ise 24 saatten fazla bir süredir tercüme edildi mi?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Hangi browseri kullaniyorsun?
opera
-
• Lütfen önerinizi tam ve net olarak açıklayın, böylece ne demek istediğinizi mümkün olduğunca kolay anlayabiliriz.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Hangi browseri kullaniyorsun?
opera
-
• Engellendiğinizde ekranda ne belirdi (Boş ekran? Oyun arayüzünün bir parçası mı? Hata mesajı?)
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Hangi browseri kullaniyorsun?
opera
-
• Kuralların hangi kısmına BGA adaptasyonu tarafından saygı gösterilmedi
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Kural ihlali oyun tekrarında görünür mü? Eğer evet ise, hangi hareket numarası?
• Hangi browseri kullaniyorsun?
opera
-
• Hangi oyun aksiyonu yapmak istedin?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Bu oyun eylemini tetiklemek için ne yapmaya çalışıyorsun?
-
• Bunu yapmaya çalıştığınızda ne oldu (hata mesajı, oyun durum çubuğu mesajı, ...)?
• Hangi browseri kullaniyorsun?
opera
-
• Oyunun hangi aşamasında sorun oluştu (mevcut oyun talimatı neydi)?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Oyunda bu hamleyi yapmaya çalıştığınızda ne oldu (hata mesajı, oyun durum çubuğu mesajı, ...)?
• Hangi browseri kullaniyorsun?
opera
-
• Lütfen görüntü sorununu açıklayın. If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Hangi browseri kullaniyorsun?
opera
-
• Lütfen görüntülenen metni kendi diliniz yerine İngilizce olarak kopyalayın/yapıştırın. If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here. Bu metin çeviri sisteminde mevcut mu? Evet ise 24 saatten fazla bir süredir tercüme edildi mi?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Hangi browseri kullaniyorsun?
opera
-
• Lütfen önerinizi tam ve net olarak açıklayın, böylece ne demek istediğinizi mümkün olduğunca kolay anlayabiliriz.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Hangi browseri kullaniyorsun?
opera
Rapor geçmişi
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).
Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.
This needs further investigation.
github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092
1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304
If a player is playing in other than English language (in my case Japanese), this logic won't work.
Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841
So I suspect this is not yet everything.
1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!
1. and 2. should be fixed. Do not restore the score data unless it is endRound state.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.
Bu rapora ekleme yap
- Başka bir masa ID / hareket ID
- F5 sorunu çözdü mü?
- Bu sorun cok mu oluyor ? Her zaman mi ? Tesadüfen mi ?
- If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here.
